Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: always output node cidr #2481

Merged
merged 3 commits into from
Oct 23, 2023
Merged

terraform: always output node cidr #2481

merged 3 commits into from
Oct 23, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Oct 19, 2023 •
edited
Loading

Context

We need to expose the node CIDR of the Constellation so that we can use the value later (in #2462) as a strict CIDR in the Cilium helm values.

Proposed change(s)

  • Always output the node CIDR and write into our state file

Additional info

Upgrade test gcp: https://github.com/edgelesssys/constellation/actions/runs/6576667618

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added the no changelog Change won't be listed in release changelog label Oct 19, 2023
@3u13r 3u13r added this to the v2.13.0 milestone Oct 19, 2023
@3u13r 3u13r requested a review from elchead as a code owner October 19, 2023 15:11
@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 15fae6b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6531518fc93a300009c5b981

@3u13r 3u13r requested a review from derpsteb as a code owner October 19, 2023 15:28
@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/helm 49.50% 49.50% 🚧
cli/internal/state 95.00% 95.00% ↔️
cli/internal/terraform 70.90% 72.10% ↗️

elchead
elchead approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm. can you please align with @msanft to potentially rebase on the self managed infra PR such that this is documented too?

@3u13r 3u13r merged commit e053d1f into main Oct 23, 2023
8 checks passed
@3u13r 3u13r deleted the feat/state/expose-node-cidr-all-csps branch October 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elchead elchead elchead approved these changes

@derpsteb derpsteb derpsteb approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@3u13r @derpsteb @elchead